Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: colexec: fix evaluation of the IN expression with INT2 and INT4 types #121955

Merged
merged 1 commit into from
Apr 9, 2024
Merged

release-23.1: colexec: fix evaluation of the IN expression with INT2 and INT4 types #121955

merged 1 commit into from
Apr 9, 2024

Conversation

yuzefovich
Copy link
Member

Backport 1/1 commits from #121904.

/cc @cockroachdb/release

This commit fixes a possible incorrect result of evaluation of the IN expression where the left side is INT2 or INT4 type and the right side has integers outside of the range of the left side's type. We do so by upcasting the "filter" row to INT8. Note that we already do the appropriate upcast in the comparison function, so the incorrect results could only be produced due to the "filter row" no longer being sorted in case a value overflows.

Fixes: #102864.

Release note (bug fix): CockroachDB could previously incorrectly evaluate IN expressions that had INT2 or INT4 type on the left side and values outside of the range of the left side on the right side. The bug has been present since at least 21.1 and is now fixed.

Release justification: bug fix.

@yuzefovich
colexec: fix evaluation of the IN expression with INT2 and INT4 types
918dd72 
This commit fixes a possible incorrect result of evaluation of the IN
expression where the left side is INT2 or INT4 type and the right side
has integers outside of the range of the left side's type. We do so by
upcasting the "filter" row to INT8. Note that we already do the
appropriate upcast in the comparison function, so the incorrect results
could only be produced due to the "filter row" no longer being sorted in
case a value overflows.

Release note (bug fix): CockroachDB could previously incorrectly
evaluate IN expressions that had INT2 or INT4 type on the left side and
values outside of the range of the left side on the right side. The bug
has been present since at least 21.1 and is now fixed.
@yuzefovich yuzefovich requested a review from a team as a code owner April 8, 2024 18:33
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Apr 8, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Apr 8, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

mgartner
mgartner approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball)

@yuzefovich yuzefovich merged commit e00cd44 into cockroachdb:release-23.1 Apr 9, 2024
6 checks passed
@yuzefovich yuzefovich deleted the backport23.1-121904 branch April 9, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgartner mgartner mgartner approved these changes

@DrewKimball DrewKimball Awaiting requested review from DrewKimball

Assignees
No one assigned
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuzefovich @cockroach-teamcity @mgartner